From 99113547e733f876cc2f8dfbe8412ed7e082d479 Mon Sep 17 00:00:00 2001 From: Matthias Andree Date: Fri, 13 Jun 2008 16:20:49 +0000 Subject: Fix Novell Bug #354291, fetchmail crashes in -v -v mode when logging long To: headers (in excess of 2048 bytes). svn path=/branches/BRANCH_6-3/; revision=5193 --- report.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'report.c') diff --git a/report.c b/report.c index 31d4e482..2a731acb 100644 --- a/report.c +++ b/report.c @@ -238,11 +238,17 @@ report_build (FILE *errfp, message, va_alist) rep_ensuresize(); #if defined(VA_START) - VA_START (args, message); for ( ; ; ) { + /* + * args has to be initialized before every call of vsnprintf(), + * because vsnprintf() invokes va_arg macro and thus args is + * undefined after the call. + */ + VA_START(args, message); n = vsnprintf (partial_message + partial_message_size_used, partial_message_size - partial_message_size_used, message, args); + va_end (args); if (n >= 0 && (unsigned)n < partial_message_size - partial_message_size_used) @@ -254,7 +260,6 @@ report_build (FILE *errfp, message, va_alist) partial_message_size += 2048; partial_message = REALLOC (partial_message, partial_message_size); } - va_end (args); #else for ( ; ; ) { -- cgit v1.2.3