From 2b2ff74b057e079b43fee6be291d8f7b1c463999 Mon Sep 17 00:00:00 2001 From: Matthias Andree Date: Sun, 14 Feb 2021 10:43:15 +0100 Subject: imap.c revise comment on timeout memory leak if auto (non-static) password buffer is used for LOGIN --- imap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'imap.c') diff --git a/imap.c b/imap.c index a7ddc45f..5f65ee47 100644 --- a/imap.c +++ b/imap.c @@ -639,7 +639,7 @@ static int imap_getauth(int sock, struct query *ctl, char *greeting) || ctl->server.authenticate == A_PASSWORD) { /* these sizes guarantee no buffer overflow */ - static char *remotename, *password; /* XXX FIXME: not thread-safe but is leaky on timeout */ + static char *remotename, *password; /* XXX FIXME: not thread-safe but dynamic buffer is leaky on timeout */ size_t rnl, pwl; rnl = 2 * strlen(ctl->remotename) + 1; pwl = 2 * strlen(ctl->password) + 1; -- cgit v1.2.3