From f773cf68c2b60a003966d8b69a6f90536fad8bd1 Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" Date: Thu, 31 Oct 1996 09:16:39 +0000 Subject: Add FIXME notes. svn path=/trunk/; revision=456 --- fetchmail.c | 2 ++ socket.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/fetchmail.c b/fetchmail.c index f7bce817..de5397b3 100644 --- a/fetchmail.c +++ b/fetchmail.c @@ -312,6 +312,8 @@ char **argv; popstatus = query_host(ctl); /* + * FIXME: This is a crock. There must be a better way... + * * Under Linux, if fetchmail is run in daemon mode * with the network inaccessible, each poll leaves a * socket allocated but in CLOSE state (this is diff --git a/socket.c b/socket.c index 6dd77f55..7a98f83f 100644 --- a/socket.c +++ b/socket.c @@ -86,6 +86,8 @@ va_dcl { } /* + * FIXME: This needs to be recoded to use stdio, if that's possible. + * * If you think these functions are too slow and inefficient, you're * absolutely right. I wish I could figure out what to do about it. * The ancestral popclient used static buffering here to cut down on the @@ -95,7 +97,7 @@ va_dcl { * The right thing to do would be to use stdio for internal per-socket * buffering here (which is why Socket() returns a file pointer) but * this causes mysterious lossage. In case someone ever finds a way - * around this, a note on the original implementation said: + * around this, a note on Carl Harris's original implementation said: * * Size of buffer for internal buffering read function * don't increase beyond the maximum atomic read/write size for -- cgit v1.2.3