From 7b9ce4568724dd2cf96da19f04214021b32e54e0 Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" Date: Wed, 3 Jun 1998 15:42:04 +0000 Subject: POP3 should work on CompuServe now. svn path=/trunk/; revision=1882 --- NEWS | 4 +++- pop3.c | 15 +++++++++------ 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/NEWS b/NEWS index 291ab288..d35fa3da 100644 --- a/NEWS +++ b/NEWS @@ -8,6 +8,7 @@ ------------------------------------------------------------------------------ fetchmail-4.4.9 (): +* 0.92 version of fetchmailconf. * Merging of command-line argument has been fixed (I think!). * Make fetchmail 64-bit clean (thanks to John Franklin ). * Fix man-page installation (thanks to Kevin Hawkins ). @@ -15,8 +16,9 @@ fetchmail-4.4.9 (): * CompuServe RPA and idfile fixes from Rich Beerman . * Hajimu UMEMOTO patched the address-rewrite logic to deal with addresses of the form "John Smith (foo) " better. +* TOP argument reduced to 99999999, the most CompuServe will accept. -There are 277 people on fetchmail-friends and 216 on fetchmail-announce. +There are 279 people on fetchmail-friends and 216 on fetchmail-announce. fetchmail-4.4.8 (Tue May 26 12:30:58 EDT 1998): * Added 0.90 beta version of fetchmailconf. diff --git a/pop3.c b/pop3.c index 5fcdc6ab..f27b3804 100644 --- a/pop3.c +++ b/pop3.c @@ -534,16 +534,19 @@ static int pop3_fetch(int sock, struct query *ctl, int number, int *lenp) * In that case, marking the seen flag is the only way to prevent the * message from being re-fetched on subsequent runs. * - * The line count passed is the maximum value of a twos-complement - * signed integer minus 1 (we take advantage of the fact that, according - * to all the POP RFCs, "if the number of lines requested by the - * POP3 client is greater than than the number of lines in the - * body, then the POP3 server sends the entire message."). + * We take advantage here of the fact that, according to all the + * POP RFCs, "if the number of lines requested by the POP3 client + * is greater than than the number of lines in the body, then the + * POP3 server sends the entire message."). + * + * The line count passed (99999999) is the maximum value CompuServe will + * accept; it's much lower than the natural value 2147483646 (the maximum + * twos-complement signed 32-bit integer minus 1) */ if (ctl->keep) gen_send(sock, "RETR %d", number); else - gen_send(sock, "TOP %d 2147483646", number); + gen_send(sock, "TOP %d 99999999", number); if ((ok = pop3_ok(sock, buf)) != 0) return(ok); -- cgit v1.2.3