aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthias Andree <matthias.andree@gmx.de>2009-01-06 18:00:21 +0000
committerMatthias Andree <matthias.andree@gmx.de>2009-01-06 18:00:21 +0000
commita804c2b676aa9629bea657e78d5e6803b85228cc (patch)
tree4f6601827cfd4c7c74edee679ec9e5046a89d04d
parentdf741344c71e5538d1c504a7d0f9ecc1d9ff4945 (diff)
downloadfetchmail-a804c2b676aa9629bea657e78d5e6803b85228cc.tar.gz
fetchmail-a804c2b676aa9629bea657e78d5e6803b85228cc.tar.bz2
fetchmail-a804c2b676aa9629bea657e78d5e6803b85228cc.zip
Fix: Do not overlap source and destination fields in snprintf() in
interface.c. Courtesy of Nico Golde, Debian. svn path=/branches/BRANCH_6-3/; revision=5260
-rw-r--r--NEWS2
-rw-r--r--interface.c2
2 files changed, 3 insertions, 1 deletions
diff --git a/NEWS b/NEWS
index 5e6d4b54..b026effb 100644
--- a/NEWS
+++ b/NEWS
@@ -54,6 +54,8 @@ fetchmail 6.3.10 (not yet released):
Details: http://blog.flameeyes.eu/2009/01/01/the-canonical-target
* Do not lose PS_MAXFETCH (13) exit status when hitting maxpoll. Reported by
Michelle Konzack, Debian Bug#508667.
+* Do not overlap source and destination fields in snprintf() in interface.c.
+ Courtesy of Nico Golde, Debian.
# TRANSLATION UPDATES AND ADDITIONS (ordered by language name):
* [it] Italian (Vincenzo Campanella)
diff --git a/interface.c b/interface.c
index c9a5db01..70e99ba9 100644
--- a/interface.c
+++ b/interface.c
@@ -271,7 +271,7 @@ get_ifinfo(const char *ifname, ifinfo_t *ifinfo)
{
kvm_read(kvmfd, ifnet_addr, &ifnet, sizeof(ifnet));
kvm_read(kvmfd, (unsigned long) ifnet.if_name, tname, sizeof tname);
- snprintf(tname, sizeof tname, "%s%d", tname, ifnet.if_unit);
+ snprintf(tname + strlen(tname), sizeof(tname) - strlen(tname), "%d", ifnet.if_unit);
if (!strcmp(tname, iname))
{