aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthias Andree <matthias.andree@gmx.de>2005-12-11 20:17:17 +0000
committerMatthias Andree <matthias.andree@gmx.de>2005-12-11 20:17:17 +0000
commit92f3cbd9697a008c65a51f67f7dd9ffe720d317c (patch)
tree5e5291829fb3f9f0563fa1148fb107bd130f84d7
parentc017bf2a4e68579c031803a6c36dea85035d30b8 (diff)
downloadfetchmail-92f3cbd9697a008c65a51f67f7dd9ffe720d317c.tar.gz
fetchmail-92f3cbd9697a008c65a51f67f7dd9ffe720d317c.tar.bz2
fetchmail-92f3cbd9697a008c65a51f67f7dd9ffe720d317c.zip
Fix segfault (null pointer dereference) on some operating systems with
fetchmail's obsolete DNS MX/host alias lookups in multidrop mode. Patch by Dr.-Ing. Andreas Haakh. svn path=/branches/BRANCH_6-3/; revision=4537
-rw-r--r--NEWS11
-rw-r--r--checkalias.c1
2 files changed, 8 insertions, 4 deletions
diff --git a/NEWS b/NEWS
index 30f1ac3c..c075606b 100644
--- a/NEWS
+++ b/NEWS
@@ -8,8 +8,8 @@ Abbreviations in parentheses are the maintainers who committed the respective
change. MA = Matthias Andree, ESR = Eric S. Raymond, RF = Rob Funk.)
# DEPRECATED FEATURES AND MAJOR INCOMPATIBLE CHANGE ADVANCE WARNINGS
-* The MX and host alias lookups that fetchmail performs in multidrop mode are
- obsolete, deprecated and may be removed from a future fetchmail version.
+* The MX and host alias DNS lookups that fetchmail performs in multidrop mode
+ are obsolete, deprecated and may be removed from a future fetchmail version.
They have never supported IPv6 (including IPv6-mapped IPv4) anyhow. (MA)
* The monitor and interface options may be removed from a future fetchmail
version as they are not sufficiently portable. (MA)
@@ -33,9 +33,12 @@ fetchmail 6.3.1 (not yet released):
that we are not using. Patch by Sunil Shetye. (MA)
* Plug potential memory and socket leak when polling multiple folders or when
the upstream sends bogus message sizes. Patch by Sunil Shetye. (MA)
-* Fix segfault in multidrop mode with headerless email.
- Reported by Daniel Drake, patch by Sunil Shetye. (MA)
+* Fix segfault (null pointer dereference) in multidrop mode with headerless
+ email. Reported by Daniel Drake, patch by Sunil Shetye. (MA)
* Update Catalan translation, by Ernest Adrogué Calveras. (MA)
+* Fix segfault (null pointer dereference) on some operating systems with
+ fetchmail's obsolete DNS MX/host alias lookups in multidrop mode.
+ Patch by Dr.-Ing. Andreas Haakh. (MA)
fetchmail 6.3.0 (released 2005-11-30):
diff --git a/checkalias.c b/checkalias.c
index fd00502f..9447ec20 100644
--- a/checkalias.c
+++ b/checkalias.c
@@ -157,6 +157,7 @@ int is_host_alias(const char *name, struct query *ctl)
hints.ai_family=AF_UNSPEC;
hints.ai_protocol=PF_UNSPEC;
hints.ai_socktype=SOCK_STREAM;
+ hints.ai_flags=AI_CANONNAME;
e = getaddrinfo(name, NULL, &hints, &res);
if (e == 0)