diff options
| author | Matthias Andree <matthias.andree@gmx.de> | 2005-07-23 16:24:00 +0000 |
|---|---|---|
| committer | Matthias Andree <matthias.andree@gmx.de> | 2005-07-23 16:24:00 +0000 |
| commit | 6f8d0b5a7434b00180e1f7bd673772eb01fe1ba7 (patch) | |
| tree | 26890daf52407e8c34cd7012cb1455e11bd46ad2 | |
| parent | 5d2dc02ed479ad06dcc003da9b869213350f31a0 (diff) | |
| download | fetchmail-6f8d0b5a7434b00180e1f7bd673772eb01fe1ba7.tar.gz fetchmail-6f8d0b5a7434b00180e1f7bd673772eb01fe1ba7.tar.bz2 fetchmail-6f8d0b5a7434b00180e1f7bd673772eb01fe1ba7.zip | |
Fix IMAP code to use password of arbitrary length from configuration
file (although not when read interactively). Debian Bug#276424.
svn path=/trunk/; revision=4170
| -rw-r--r-- | NEWS | 3 | ||||
| -rw-r--r-- | imap.c | 13 |
2 files changed, 13 insertions, 3 deletions
@@ -137,6 +137,9 @@ OTHER CHANGES: * Make ODMR really silent, suppress "fetchmail: receiving message data". Fixes Debian Bug#296163. Matthias Andree. * Add From: header to warning emails. Debian Bug#244828. Matthias Andree. +* Fix IMAP code to use password of arbitrary length from configuration + file (although not when read interactively). Debian Bug#276424. + Matthias Andree fetchmail-6.2.5 (Wed Oct 15 18:39:22 EDT 2003), 23079 lines: @@ -504,14 +504,21 @@ static int imap_getauth(int sock, struct query *ctl, char *greeting) || ctl->server.authenticate == A_PASSWORD) { /* these sizes guarantee no buffer overflow */ - char remotename[NAMELEN*2+1], password[PASSWORDLEN*2+1]; + char *remotename, *password; + size_t rnl, pwl; + rnl = 2 * strlen(ctl->remotename) + 1; + pwl = 2 * strlen(ctl->password) + 1; + remotename = xmalloc(rnl); + password = xmalloc(pwl); - imap_canonicalize(remotename, ctl->remotename, NAMELEN); - imap_canonicalize(password, ctl->password, PASSWORDLEN); + imap_canonicalize(remotename, ctl->remotename, rnl); + imap_canonicalize(password, ctl->password, pwl); snprintf(shroud, sizeof (shroud), "\"%s\"", password); ok = gen_transact(sock, "LOGIN \"%s\" \"%s\"", remotename, password); shroud[0] = '\0'; + free(password); + free(remotename); #ifdef SSL_ENABLE /* this is for servers which claim to support TLS, but actually * don't! */ |