aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthias Andree <matthias.andree@gmx.de>2006-12-12 17:00:02 +0000
committerMatthias Andree <matthias.andree@gmx.de>2006-12-12 17:00:02 +0000
commit1834845f2c19d89d09d46b83760bfb18676274e6 (patch)
tree7f2dea48570fc0c76f11b6a1356da31b5b52dc38
parent6419d6f7beb6af32facab158fcfb4f2dc973ccf0 (diff)
downloadfetchmail-1834845f2c19d89d09d46b83760bfb18676274e6.tar.gz
fetchmail-1834845f2c19d89d09d46b83760bfb18676274e6.tar.bz2
fetchmail-1834845f2c19d89d09d46b83760bfb18676274e6.zip
Remove excess no-op strcpy() after strdup() found by Andreas Krennmair.
svn path=/branches/BRANCH_6-3/; revision=4989
-rw-r--r--NEWS3
-rw-r--r--sink.c1
2 files changed, 3 insertions, 1 deletions
diff --git a/NEWS b/NEWS
index 40e13eb5..ccf5e70f 100644
--- a/NEWS
+++ b/NEWS
@@ -88,6 +88,9 @@ fetchmail 6.3.6 (not yet released):
* Fix crash on systems that do not provide strdup() in out-of-memory conditions.
Patch by Andreas Krennmair.
+# CHANGES:
+* Remove excess no-op strcpy() after strdup() found by Andreas Krennmair.
+
# TRANSLATIONS:
* New en_GB (British English) translation by David Lodge.
* Update Japanese (Takeshi Hamasaki), Polish (Jakub Bogusz), Russian (Pavel
diff --git a/sink.c b/sink.c
index e2d8c7a7..92477ef9 100644
--- a/sink.c
+++ b/sink.c
@@ -957,7 +957,6 @@ transient:
case PS_SUCCESS:
#ifdef EXPLICIT_BOUNCE_ON_BAD_ADDRESS
from_responses[*bad_addresses] = xstrdup(smtp_response);
- strcpy(from_responses[*bad_addresses], smtp_response);
#endif /* EXPLICIT_BOUNCE_ON_BAD_ADDRESS */
(*bad_addresses)++;