From c2e9d2acf3159ebd6ff6ed28513945eb62d05265 Mon Sep 17 00:00:00 2001 From: vg Date: Mon, 23 Jun 2025 21:32:24 +0200 Subject: Remove contact field management Since June 4 2025, letsencrypt don't return contact information anymore from newAccount api point. More information at https://community.letsencrypt.org/t/support-ended-for-expiration-notification-emails/238173 acme_tiny_dns could be used with little modification outside letsencrypt, but I'm aligned with the rationale given by letsencrypt on why they removed contact information from their database. So this commit removes contact management for the following reasons: - without modifying the code (even if the modifications would be small), the client does not work as the key 'contact' is not found anymore in the json structure returned by the newAccount url. - this client main target is letsencrypt and does not seek to be complete. - this simplifies the script by reducing the code and having less features. - I think, like explained by letsencrypt in addition to private data issues, that reminders of an expiring certificate can be monitored by other means. Monit for example can do it, and there exists also online services for this if needed. See https://letsencrypt.org/2025/01/22/ending-expiration-emails/ for more information. --- tests/test_acme_dns_tiny.py | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) (limited to 'tests') diff --git a/tests/test_acme_dns_tiny.py b/tests/test_acme_dns_tiny.py index 3a29ce4..ffbe0b6 100644 --- a/tests/test_acme_dns_tiny.py +++ b/tests/test_acme_dns_tiny.py @@ -26,7 +26,6 @@ acme_dns_tiny.log_configure = False ACME_STAGING_DIRECTORY = \ 'https://acme-staging-v02.api.letsencrypt.org/directory' DOMAIN = os.getenv('TEST_DOMAIN') -CONTACT = os.getenv('TEST_CONTACT') # form: mailto:name@domain SCRIPT = os.getenv('TEST_SCRIPT') @@ -158,13 +157,8 @@ def subj_fixture(request): CSR_ARGS_COUNTER = 0 @pytest.fixture(scope='module', params=[ - pytest.param(None, id='no_separator/no_contact'), + pytest.param(None, id='no_separator'), pytest.param({'args': {'--separator': '\\0'}}, id='separator'), - pytest.param({'args': {'--contact': [CONTACT]}}, id='contact'), - pytest.param({'args': { - '--contact': [CONTACT], - '--separator': '\\0', - }}, id='separator+contact'), ]) def main_args(tmpdir_factory, account_domain_key, request, subj_fixture): @@ -183,7 +177,6 @@ def main_args(tmpdir_factory, account_domain_key, request, subj_fixture): #'--ttl': 60, # already the default '--ttl': None, '--separator': None, - '--contact': None, '--verbose': None, '--quiet': None, } @@ -219,7 +212,6 @@ def main_args(tmpdir_factory, account_domain_key, request, subj_fixture): def test_sanity_env(): 'check environment is correctly set before running other tests' assert bool(DOMAIN) - assert bool(CONTACT) assert bool(SCRIPT) -- cgit v1.2.3